Skip to content

Add new powershell.codeFormatting settings for new options in PSSA 1.18: PipelineIndentationStyle #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Dec 20, 2018

PR Summary

Add powershell.codeformatting.pipelineIndentationStyle setting to use new PSSA option to be added in this PR. The dependent PSES PR is here
This PR can only be merged once PSSA 1.18 has released and the dependent PSES has been merged.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bergmeister!!

@TylerLeonhardt
Copy link
Member

@bergmeister I assume this one is also ok to merge?

@bergmeister bergmeister changed the title [Do not merge yet] Add new powershell.codeFormatting settings for new options in PSSA 1.18: PipelineIndentationStyle Add new powershell.codeFormatting settings for new options in PSSA 1.18: PipelineIndentationStyle Mar 20, 2019
@bergmeister
Copy link
Contributor Author

Yes, I renamed it.

@TylerLeonhardt TylerLeonhardt merged commit 4d73772 into PowerShell:master Mar 20, 2019
bergmeister added a commit to bergmeister/vscode-powershell that referenced this pull request Mar 20, 2019
…18: PipelineIndentationStyle (PowerShell#1669)

* Add powershell.codeformatting.pipelineIndentationStyle setting

* fix indentation
This was referenced Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants